On Fri, 6 Jan 2023 23:59:57 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 101 commits: >> >> - Merge remote-tracking branch 'origin/master' into 8293119.constrained >> - 8293119: removed debug printouts >> - Merge remote-tracking branch 'origin/master' into 8293119.constrained >> - width indicator in tester >> - 2023 >> - 2023 >> - small delta >> - whitespace >> - whitespace >> - Merge remote-tracking branch 'origin/master' into 8293119.constrained >> - ... and 91 more: https://git.openjdk.org/jfx/compare/ca29cc61...795d196e > > modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ResizeHelper.java > line 146: > >> 144: } >> 145: } >> 146: } while (needsAnotherPass); > > I presume this won't get stuck in an infinite loop? I think it's fine, since > the only time it will set `needsAnotherPass` is when it removes a column from > consideration, and eventually, if all columns get removed, it will return > anyway because `total` will be zero. So I think this is fine. you are right - this code always finishes. > tests/manual/tester/src/com/oracle/javafx/tester/ATableViewResizeTester.java > line 63: > >> 61: * Tests TableView/JTable constrained column resize modes. >> 62: */ >> 63: public class ATableViewResizeTester extends Application { > > Minor: Maybe drop the initial `A` and just call it `TableViewResizeTester`? > The "A" seems odd. > > Suggestion: it would be useful to have a `TreeTableView` tester. I presume > you have done at least some testing with `TreeTableView`? With your permission, I'll keep it unchanged in this PR, but will make it a part of the monkey tester [JDK-8299335](https://bugs.openjdk.org/browse/JDK-8299335) later. (it's already implemented in a temp repo, both TableView and TreeTableView: https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/monkey/pages/TableViewPage.java https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/monkey/pages/TreeTableViewPage.java ------------- PR: https://git.openjdk.org/jfx/pull/897
