On Mon, 2 Jan 2023 14:10:20 GMT, Lukasz Kostyra <[email protected]> wrote:

>> Creating a not-displayed node and then modifying its contents caused JFX to 
>> not consume its old dirty region and thus not update it. When such node was 
>> displayed, its old dirty region was used for drawing, which in some cases 
>> (ex. new content taking more space - a Label having more text as in bug 
>> request) caused it to clip.
>> 
>> Resolved by always unionizing dirty regions with new bounds when calculating 
>> Node's transformed bounds.
>> 
>> Change was tested on macOS and Windows 10 and does not affect any tests.
>
> Lukasz Kostyra has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   NGNode: Change comment at dirty bounds update for clarification

LGTM

-------------

Marked as reviewed by arapte (Reviewer).

PR: https://git.openjdk.org/jfx/pull/978

Reply via email to