On Fri, 23 Dec 2022 17:26:22 GMT, Karthik P K <k...@openjdk.org> wrote:
>> Do you think it's worth doing this as a unit test? > > I think it is good to add unit test to test the example code. Only thing I'm > looking at is that if the example changes in future, we need to make sure > that corresponding `MyButton` class is updated in unit test. > Since the example code might not change frequently, we can add unit test. I agree, let's add a unit test, unless `StyleablePropertyFactoryTest` covers the same scenario. ------------- PR: https://git.openjdk.org/jfx/pull/983