On Fri, 23 Dec 2022 13:54:56 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
>> This PR was previously discussed on #905. >> >> The approach is to grab the keyboard focus so the window that originated the >> drag will keep it. >> >> I did some cleanup on grabbing related functions as well. >> >> `gdk_keyboard_focus()` is deprecated, so is `gdk_device*` functions in favor >> of `gdk_seat*`. But that's only available in later Gtk versions. I checked >> and newer Gtk will use `gdk_seat*` inside the deprecated >> `gdk_keyboard_focus()`. >> >> Edit: >> >> The current changes uses another approach that is to not ungrab pointer >> device when focus is received on another window. There's also some cleanup >> on grabbing related functions and grab moved from starting on mouse click to >> the actual drag. > > Thiago Milczarek Sayao has updated the pull request incrementally with one > additional commit since the last revision: > > Only grab once drag starts Looks good now. Thanks. ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.org/jfx/pull/977
