On Mon, 12 Dec 2022 05:41:45 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
> The commit#1 changes look good. I would recommend to revert commit#2 for few > reasons: > > 1. Cleanup changes are a lot more than actual fix change. > 2. It will be difficult to revisit in future. > 3. If required the cleanup changes could go in as a separate fix. > > Could you please provide link to the discussion that led to this change? @arapte the discussion was part of fixing warnings in javafx.graphics. You can find it here (open first resolved comment): https://github.com/openjdk/jfx/pull/960#pullrequestreview-1197937273 ------------- PR: https://git.openjdk.org/jfx/pull/966
