On Wed, 23 Nov 2022 19:15:03 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293119: newline
>
> modules/javafx.controls/src/main/java/javafx/scene/control/ConstrainedColumnResizeBase.java
> line 34:
>
>> 32: * @since 20
>> 33: */
>> 34: public abstract class ConstrainedColumnResizeBase {
>
> Do you think this class would benefit from a generic parameter for the
> specific type (`TableView.ResizeFeatures` or `TreeTableView.ResizeFeatures`)?
> In order for that to be useful, it would also need to extend `Callback` and
> declare an abstract call method using the generic type. I don't know whether
> this is worth it or not.
Actually, this class (and `ConstrainedColumnResize`) do not need to be generic.
I think it was a bit of oversight or perhaps
`TableColumnBase`/`ResizeFeaturesBase` was a late addition.
-------------
PR: https://git.openjdk.org/jfx/pull/897
