On Mon, 12 Sep 2022 12:31:12 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
>>> wondering about your comment in the bug report: you stated that you can >>> reproduce it on Win, does this imply you couldn't on Mac? >> >> I hadn't tried running `HorizontalConstrainedTableScrollingMin` on Mac, >> since Andy said he couldn't reproduce it with that program. I just now ran >> it, and no, that specific program doesn't show the bug on Mac. However, the >> unit test in this PR _does_ fail on Mac without the fix, and passes with the >> fix. > >> >> I hadn't tried running `HorizontalConstrainedTableScrollingMin` on Mac, >> since Andy said he couldn't reproduce it with that program. I just now ran >> it, and no, that specific program doesn't show the bug on Mac. However, the >> unit test in this PR _does_ fail on Mac without the fix, and passes with the >> fix. > > thanks for checking, really wanted to know :) > > Yes, the tests here are failing/passing before/after (no real wonder if the > hbar is hidden in constraint mode) - what bothered me was this on/off at > certain widths, which I could see in a visual test but not reproduce with the > stub toolkit. We have/had seen similar issues related to hidpi on Win. And I > think I have a system test that passes with scale 1 and fails with scale > 1 > (both before the fix here). Naturally passing after .. @kleopatra or @aghaisas can one of you be a second reviewer? ------------- PR: https://git.openjdk.org/jfx/pull/894
