On Tue, 16 Aug 2022 15:58:38 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle >> project in eclipse and all nested projects in the workspace compile with no >> errors. >> >> - updated .classpath entries in apps/ >> - added utf-8 prefs in .settings/ > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 13 additional > commits since the last revision: > > - Merge branch 'openjdk:master' into 8290473.apps > - Merge branch 'openjdk:master' into 8290473.apps > - 8290473: removed empty src sir > - 8290473: whitespace > - 8290473: init shader dirs > - 8290473: junit 5 > - Merge remote-tracking branch 'origin/master' into 8290473.apps > - 8290473: removed eclipse project in buildSrc > - 8290473: whitespace > - 8290473: added initDirs task > - ... and 3 more: https://git.openjdk.org/jfx/compare/900277ad...e86cb390 I also noticed that the `jfx` project is still named `rt` in its project file. Please fix that on the way. While it's possible to run apps, the project structure is wrong in that the source folders are projects and the folders are packages. ColorCube has the right configuration. A follow up for apps and test is needed. apps/samples/.classpath line 21: > 19: <classpathentry kind="lib" path="Ensemble8/lib/lucene-core-7.7.3.jar"/> > 20: <classpathentry kind="lib" > path="Ensemble8/lib/lucene-grouping-7.7.3.jar"/> > 21: <classpathentry kind="lib" > path="Ensemble8/lib/lucene-queryparser-7.7.3.jar"/> I'm getting the following errors on Samples: Description Resource Path Location Type Project 'samples' is missing required library: 'Ensemble8/lib/lucene-core-7.7.3.jar' samples Build path Build Path Problem Project 'samples' is missing required library: 'Ensemble8/lib/lucene-grouping-7.7.3.jar' samples Build path Build Path Problem Project 'samples' is missing required library: 'Ensemble8/lib/lucene-queryparser-7.7.3.jar' samples Build path Build Path Problem Project 'samples' is missing required source folder: '3DViewer/src/test/java' samples Build path Build Path Problem Project 'samples' is missing required source folder: '3DViewer/src/test/resources' samples Build path Build Path Problem Indeed, there is no `3DViewer/src/test` folder. How do you not get errors? apps/toys/.classpath line 9: > 7: </classpathentry> > 8: <classpathentry kind="src" path="FX8-3DFeatures/src"/> > 9: <classpathentry kind="src" path="Hello/src/main/java"/> Why are these the only 2 sources? build.gradle line 2508: > 2506: // Create empty hlsl dirs on all platforms for IDE support > 2507: file("$project.buildDir/hlsl/Decora").mkdirs() > 2508: file("$project.buildDir/hlsl/Prism").mkdirs() You need to create `build/gensrc/jsl-decora` and `build/gensrc/jsl-prism` too if they are not declared as optional sources in the classpath. buildSrc/.settings/org.eclipse.core.resources.prefs line 2: > 1: eclipse.preferences.version=1 > 2: encoding/<project>=UTF-8 This file can be removed too since buildSrc is not a project. ------------- Changes requested by nlisker (Reviewer). PR: https://git.openjdk.org/jfx/pull/858
