> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect > statement "Is functionally equivalent to calling > <code>getSelectedIndices().contains(index)</code>." > 2. reimplement TableView.TableViewSelectionModel.isSelected(int) method to > return true when at least one cell in *any* column is selected on the given > row (was: *all* columns) > 3. change selectRowWhenInSingleCellSelectionMode() and > selectRowWhenInSingleCellSelectionMode2() in TableViewSelectionModelImplTest > to reflect new reality. > > NOTE: proposed change alters semantics of isSelected(int) method (in the > right direction, in my opinion).
Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into 8235491.isselected - 8235491: updated test - 8235491: removed unnecessary method - 8235491: delegate to super() - 8235491: revert clear selection - 8235491: whitespace - 8235491: additional tests - Merge remote-tracking branch 'origin/master' into 8235491.isselected - 8235491: javadoc - 8235491: tree table view - ... and 6 more: https://git.openjdk.org/jfx/compare/03253b00...35247bc6 ------------- Changes: - all: https://git.openjdk.org/jfx/pull/839/files - new: https://git.openjdk.org/jfx/pull/839/files/76466935..35247bc6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=839&range=09 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=839&range=08-09 Stats: 480 lines in 6 files changed: 450 ins; 10 del; 20 mod Patch: https://git.openjdk.org/jfx/pull/839.diff Fetch: git fetch https://git.openjdk.org/jfx pull/839/head:pull/839 PR: https://git.openjdk.org/jfx/pull/839
