Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc

[Andy Goryachev]

On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/

@nlisker :
could you please take a look at this draft PR?
with these changes, I get no errors in eclipse, I can run tests and standalone 
applications.

I still cannot launch apps - for example, Jfx3dViewerApp fails with 

Error: JavaFX runtime components are missing, and are required to run this 
application

Here is the command line eclipse generates:

Thank you, Kevin.

The goal of this PR is to enable simultaneous development in jfx and the apps 
or tests in Eclipse.  I should be able to modify and debug the code in both 
parts.  Of course, in case of tests, the final test is using gradle test as it 
guarantees to set up every dependency just right.

I specifically do not want to run apps against jars, as I won't be able to use 
eclipse incremental build feature and see the changes immediately.

I can run/debug the tests in Eclipse.  With apps, using the same configuration 
essentially, I am getting


Error: JavaFX runtime components are missing, and are required to run this 
application

Not sure what runtime components are missing (I wish the error message was more 
descriptive).

-andy




From: Kevin Rushforth ***@***.***>
Date: Monday, 2022/08/01 at 10:16
To: openjdk/jfx ***@***.***>
Cc: Andy Goryachev ***@***.***>, Author ***@***.***>
Subject: [External] : Re: [openjdk/jfx] 8290473: update Eclipse .classpath in 
apps, buildSrc (PR #858)

One quick comment. Compiling or running the apps should not need any additional 
--add-exports, --add-reads, or --add-opens arguments, and they should not need 
to load the shims or junit. Those should only be needed for building and 
running unit tests. Applications should be run with just the modular jars.

—
Reply to this email directly, view it on 
GitHub<https://urldefense.com/v3/__https:/github.com/openjdk/jfx/pull/858*issuecomment-1201488198__;Iw!!ACWV5N9M2RV99hQ!PY9Nl358R0mxtlAKTfWc3EswBefXVfPSNlbCQbxGD7VqQTFV6YRFw2bQmNG41JpGe5kzoT4jVympbfnC_C--aN0ALML5NQ$>,
 or 
unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AZQ34ZDRIR3INCBQL54B64LVXABALANCNFSM55IG4DNQ__;!!ACWV5N9M2RV99hQ!PY9Nl358R0mxtlAKTfWc3EswBefXVfPSNlbCQbxGD7VqQTFV6YRFw2bQmNG41JpGe5kzoT4jVympbfnC_C--aN0zXxVJ_A$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>

Thanks to Kevin's help, we were able to launch an ColorCube app with the 
following configuration (below).  The key point is to Override Dependencies and 
-add-modules directly, instead of --add-exports that Eclipse adds by default:

<img width="856" alt="Screen Shot 2022-08-01 at 12 03 00" 
src="https://user-images.githubusercontent.com/107069028/182226859-b3609357-5a9a-4121-a841-31ed34ee8409.png";>

-------------

PR: https://git.openjdk.org/jfx/pull/858