On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> - replaced with exact functional equivalent (in the presence of exceptions, >> for example) > > Andy Goryachev has updated the pull request incrementally with two additional > commits since the last revision: > > - 8289397: review comments > - Revert "8289397: functional equivalent" > > This reverts commit 6ae0ef60b186c75993fe7faa099140b26593d308. I think there is enough agreement on the two assignments that you have factored out for you to proceed. The only question then is the `assertionEnabled` method. If you want to make that change so that there are no more warnings of this type, I won't object, but I do want to see a comment explaining it (I think it is less clear than before, although the previous comment wasn't all that great). I left a recommendation inline. ------------- PR: https://git.openjdk.org/jfx/pull/851
