On Thu, 21 Jul 2022 11:58:19 GMT, Florian Kirmaier <fkirma...@openjdk.org>
wrote:
>> This PR switches the Thread to the QuantumRenderer, in the case the Disposer
>> is called from another Thread - the printing Thread.
>> I'm open for better solutions on how to fix this Issue.
>> Initially i thought there is also a Race Condition in the resource pool, but
>> a new one is created for the Printing Thread.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> JDK-8271395
> changes based on codereview
> We now catch Throwable instead of Exception
The changes look fine now. Since this PR is so out of date w.r.t. master, can
you merge the upstream master into your PR branch? I'll do some quick testing
and then approve it, once you do.
You will also need to update the title of this PR to match the JBS issue (the
JBS bug title is the better one), before it can be integrated.
modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java
line 460:
> 458: });
> 459: latch.await();
> 460: } catch (Throwable e) {
Not sure whether we need to catch `Throwable` here, but we use that pattern all
over the place in this file, so it can be reexamined as part of the cleanup bug
I will file.
-------------
PR: https://git.openjdk.org/jfx/pull/618
