On Fri, 8 Jul 2022 21:37:47 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

> The fix includes:
> - renaming of offending methods to avoid confusion
> - explicitly declaring the offending methods as private

On GitHub there is no way to dismiss an approval other than to submit a review 
with "Changes Requested", which I did. So there are no specific changes 
requested.

What is needed is to finish the review and answer the general questions that 
have been raised as to the direction we should go. There doesn't seem to be 
agreement that the code changes proposed in this PR are the ones we should be 
making, so let's continue the discussion. I don't think there is any urgency on 
this one, but let's see where the discussion goes.

-------------

PR: https://git.openjdk.org/jfx/pull/824

Reply via email to