Anil - you had several review comments on this - can you check if the code changes are OK as per your review?
On Thu, Aug 11, 2016 at 9:50 AM, Alfasi, Shlomi <[email protected]> wrote: > Hi All, > > When do you think this patch can be merged? > > Shlomi Alfasi > ------------------------------ > *From:* Radune, Slava > *Sent:* Aug 11, 2016 9:37 AM > *To:* Abhijit Kumbhare; Alfasi, Shlomi > *Cc:* Anil Vishnoi; Sam Hague; Michal Polkorab; openflowplugin-dev@lists. > opendaylight.org; Kochba, Alon; Mainzer, Gal > *Subject:* RE: https://git.opendaylight.org/gerrit/#/c/42702/ > > Hi! > > It is about to be commited. > > I have already fixed the CR. > > And It is ready for commit. > > > > [image: 11753793_1119058104774946_1459712243_n.002 (1)] > > > > *From:* Abhijit Kumbhare [mailto:[email protected]] > *Sent:* Wednesday, August 10, 2016 1:42 AM > *To:* Alfasi, Shlomi <[email protected]>; Radune, Slava < > [email protected]> > *Cc:* Anil Vishnoi <[email protected]>; Sam Hague <[email protected]>; > Michal Polkorab <[email protected]>; openflowplugin-dev@lists. > opendaylight.org; Kochba, Alon <[email protected]>; Mainzer, Gal < > [email protected]> > *Subject:* Re: https://git.opendaylight.org/gerrit/#/c/42702/ > > > > Shlomi, Slava, > > > > What is the status of this patch? I have sent an API waiver. I see a -1 > from Anil today - as well as some updates from you. > > > > Thanks, > > Abhijit > > > > > > On Thu, Aug 4, 2016 at 5:33 PM, Abhijit Kumbhare <[email protected]> > wrote: > > Hi Shlomi, > > > > I will shortly send an API waiver request - and we can merge it tomorrow > morning after projects have had a chance to check it. > > > > Thanks, > > Abhijit > > > > > > On Thu, Aug 4, 2016 at 2:43 PM, Alfasi, Shlomi <[email protected]> > wrote: > > HI Abhijit, > > We have this review in openflowplugin ready and we would like to merge it > before netvirt code freeze since other projects depends on it (genius, > netvirt). > > This code includes only addition functionalities (support for learn > action) and does not change any existing api’s. > > Can someone look at that and merge if possible? > > > > Shlomi Alfasi > > > > >
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
