Stefen, Raphael +1 What about to have 2 sections in http://odoo-community.org/page/website.how-to
- "Mandatory" rules: pep8 ... that will block PR if not respected; - "Nice to Have" rules with sandy's remarks (and others conventions), that will not block PR; My 2 cents. *Sylvain LE GAL* * Service informatiqueGroupement Régional Alimentaire de Proximité* 3 Grande rue des feuillants 69001 Lyon *Bureau : *(+33) 09.72.32.33.17 *Astreinte :* (+33) 06.81.85.61.43 *Site Web** : *www.grap.coop *Twitter : *@legalsylvain* <https://twitter.com/legalsylvain>* 2014-10-21 14:37 GMT+02:00 Raphael Valyi <rva...@gmail.com>: > Hello, I share the same opinion as Stefan about this. > In any case we should not forget the big picture and loose our energy on > details that could easily become void depending on the big picture, even if > ideally enforcing such guidelines will be great for new stuff or > refactoring. > > Regards and thanks for the work. > > On Tue, Oct 21, 2014 at 10:15 AM, Stefan <ste...@therp.nl> wrote: > >> On 20-10-14 16:52, Sandy Carter wrote: >> > What the consensus I seem to get out of this is: Often it is better to >> > separate the models (especially in xml), but there are some acceptable >> > exceptions: >> > >> > * Small changes to models >> > * One to many relationships (single column add to related model) >> > * At some point, a small change becomes to big and the file must be >> split. >> > * All changes are very closely related to a same feature >> > * Wizards >> > * Connectors (I'm adding this one) >> > >> > No one seemed to object to naming the Class, .py file and xml files >> > according to the model (or largest model in the case of filenames). >> > >> > Is this something we can agree on? >> >> Thanks for writing such a clear motivation! I support your proposal, as >> long as refactorings along these lines will not be demanded in reviews >> of small bug fixing pull requests in legacy modules. >> >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~openerp-community >> Post to : openerp-community@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~openerp-community >> More help : https://help.launchpad.net/ListHelp >> > > > _______________________________________________ > Mailing list: https://launchpad.net/~openerp-community > Post to : openerp-community@lists.launchpad.net > Unsubscribe : https://launchpad.net/~openerp-community > More help : https://help.launchpad.net/ListHelp > >
_______________________________________________ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
