On Fri, Oct 25, 2024 at 8:49 AM Chanh Nguyen <[email protected]> wrote: > > > > On 24/10/2024 22:22, Khem Raj wrote: > > On Thu, Oct 24, 2024 at 7:57 AM Chanh Nguyen > > <[email protected]> wrote: > >> > >> > >> > >> On 24/10/2024 21:46, Chanh Nguyen wrote: > >>> > >>> > >>> On 24/10/2024 19:18, Khem Raj wrote: > >>>> Please test it and wait it to merge before sending pull request here, > >>>> feature branches are temporary and usually not something we use in OE > >>>> > >>> > >>> Yes Khem, it is only temporary for CI build checking. > >>> > >>> Can you please help run CI build? If any other errors, we'll fix. > >>> > >>> Thanks, > >>> Chanh > >>> > >> I and Jeremy used the musl compiler (https://musl.cc/), and it compiled > >> the MCTP successfully. It seems the error just happens with your CI run, > >> and we haven't known to run the CI to check. > >> > > > > As I mentioned before, the combination is clang19 + musl, musl.cc is > > gcc+musl only so > > you won't see clang specific issues with it. > > That's fine if you can say [RFT] in the subject line to convey the > > intention. > > > > Thank Khem for your instruction about subject patch! > > Should I resend this patch with new subject ? It will be > [RFT][meta-networking][PATCH] mctp: Fix CI build error with musl+clang
Not this time, since I have staged it for testing and it seems to work for musl+clang case AFAICT so please send the final patch with version bump to include the fixes that Jeremy is pushing into component repo > > >>>> On Wed, Oct 23, 2024 at 11:52 PM Chanh Nguyen > >>>> <[email protected]> wrote: > >>>>> > >>>>> Hi Khem, > >>>>> > >>>>> This is only a temporary patch. It helps check CI build errors on the > >>>>> MCTP repo. Please help run the CI build; if any error you can show here, > >>>>> then Jeremy will update the mctp repo to fix errors. > >>>>> > >>>>> Please don't merge this patch. When the CI builds completely without any > >>>>> errors, I will push a new patch with the latest version on the MCTP > >>>>> repo. > >>>>> > >>>>> Thanks, > >>>>> > >>>>> Chanh > >>>>> > >>>>> On 24/10/2024 13:51, Chanh Nguyen wrote: > >>>>>> Signed-off-by: Chanh Nguyen <[email protected]> > >>>>>> --- > >>>>>> meta-networking/recipes-support/mctp/mctp_2.0.bb | 4 ++-- > >>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>>>>> > >>>>>> diff --git a/meta-networking/recipes-support/mctp/mctp_2.0.bb b/ > >>>>>> meta-networking/recipes-support/mctp/mctp_2.0.bb > >>>>>> index c6aa7c104..793afe755 100644 > >>>>>> --- a/meta-networking/recipes-support/mctp/mctp_2.0.bb > >>>>>> +++ b/meta-networking/recipes-support/mctp/mctp_2.0.bb > >>>>>> @@ -5,9 +5,9 @@ LICENSE = "GPL-2.0-only" > >>>>>> > >>>>>> LIC_FILES_CHKSUM = "file:// > >>>>>> LICENSE;md5=4cc91856b08b094b4f406a29dc61db21" > >>>>>> > >>>>>> -SRCREV = "f110926b082731b25720b444378ad55d7a9d451d" > >>>>>> +SRCREV = "089dc53fa7387cca517cd713061c323ca06fb6dd" > >>>>>> > >>>>>> -SRC_URI = "git://github.com/CodeConstruct/ > >>>>>> mctp;branch=main;protocol=https" > >>>>>> +SRC_URI = "git://github.com/CodeConstruct/mctp;branch=dev/cross- > >>>>>> fixes;protocol=https" > >>>>>> > >>>>>> S = "${WORKDIR}/git" > >>>>>> > >>>>> > >>> > >> >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#113228): https://lists.openembedded.org/g/openembedded-devel/message/113228 Mute This Topic: https://lists.openembedded.org/mt/109186060/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
