> -----Original Message----- > From: Alexander Kanavin [mailto:alexander.kana...@linux.intel.com] > Sent: den 15 juni 2017 22:44 > To: Peter Kjellerstedt <peter.kjellerst...@axis.com>; Burton, Ross > <ross.bur...@intel.com> > Cc: OE-core <openembedded-core@lists.openembedded.org>; Kukkonen, Jussi > <jussi.kukko...@intel.com> > Subject: Re: [OE-core] [PATCH 01/11] gtk+3: Update the patches to work > without PATCHTOOL = "git" > > On 06/15/2017 06:33 PM, Peter Kjellerstedt wrote: > > It turns out the problem is only seen if opengl is enabled in > > DISTRO_FEATURES. However, since that is the default for poky, that > > still does not explain why others do not see the problem > > > > I have included the log.do_compile file where one can see that the > > file gdkx-with-gl-context.h is missing (that is the file that was > > supposed to be renamed from gdkx.h by the patch). When I look in > > tmp/work/i586-poky-linux/gtk+3/3.22.15-r0/gtk+-3.22.15/gdk/x11 I see > > gdkx.h and gdkx-without-gl-context.h, instead of the expected > > gdkx-with-gl-context.h and gdkx-without-gl-context.h... > > I guess Jussi needs to look at this, as he's maintaining the patches > and the recipe. > > Alex
Ok, I have finally figured out what is going on. The problem is the version of patch that is installed on the host. Support for Git style patches was added to patch in version 2.7, but on the host where I failed to build gtk+3, the installed version of patch is 2.6.1... However, since this is the only patch in all of Poky and OpenEmbedded that uses the Git style format, I still think the correct thing to do is to apply my change. It does not change the contents of the patch, only the format. I will send an updated change with an updated commit message to clarify what is going on. //Peter -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
