On Thu, Jun 22, 2017 at 9:48 PM, Robert Yang <liezhi.y...@windriver.com> wrote:
> > > On 06/22/2017 11:07 PM, Bruce Ashfield wrote: > >> >> >> On Thu, Jun 22, 2017 at 4:30 AM, Robert Yang <liezhi.y...@windriver.com >> <mailto:liezhi.y...@windriver.com>> wrote: >> >> The following commit has removed rpc ports from >> runqemu-export-rootfs, so >> runqemu should also remove them, otherwise "runqemu nfs" doesn't >> work. And use >> abspath for nfsroot, otherwise it doesn't work when it is a relative >> path. >> >> >> That change in question was discussed on list and was supposed to be >> optional. >> >> Can you confirm that a non-root user can still do a NFS root with both of >> these >> changes applied ? >> > > The runqemu-export-rootfs uses UNFS, no root privilege is required, I can > confirm that both "runqemu slirp nfs" and "runqemu nfs" work well, so I > assume > the answer is yes. > Yes, that's good enough to confirm the old functionality. As long as non-privileged ports can be used, we should be fine. Bruce > > // Robert > > >> Bruce >> >> >> commit 6bb9860ef7ba9c84fe9bd3a81aa6555f67ebd38e >> Author: Cody P Schafer <d...@codyps.com <mailto:d...@codyps.com>> >> Date: Tue Jun 6 18:30:49 2017 -0400 >> >> runqemu-export-rootfs: don't change RPC ports >> >> [YOCTO #11687] >> >> Signed-off-by: Robert Yang <liezhi.y...@windriver.com >> <mailto:liezhi.y...@windriver.com>> >> >> --- >> scripts/runqemu | 8 ++------ >> 1 file changed, 2 insertions(+), 6 deletions(-) >> >> diff --git a/scripts/runqemu b/scripts/runqemu >> index 26328e5b512..41b870c9f7c 100755 >> --- a/scripts/runqemu >> +++ b/scripts/runqemu >> @@ -784,16 +784,12 @@ class BaseConfig(object): >> all_instances.sort(key=int) >> self.nfs_instance = int(all_instances.pop()) + 1 >> >> - mountd_rpcport = 21111 + self.nfs_instance >> - nfsd_rpcport = 11111 + self.nfs_instance >> nfsd_port = 3049 + 2 * self.nfs_instance >> mountd_port = 3048 + 2 * self.nfs_instance >> >> # Export vars for runqemu-export-rootfs >> export_dict = { >> 'NFS_INSTANCE': self.nfs_instance, >> - 'MOUNTD_RPCPORT': mountd_rpcport, >> - 'NFSD_RPCPORT': nfsd_rpcport, >> 'NFSD_PORT': nfsd_port, >> 'MOUNTD_PORT': mountd_port, >> } >> @@ -801,7 +797,7 @@ class BaseConfig(object): >> # Use '%s' since they are integers >> os.putenv(k, '%s' % v) >> >> - >> self.unfs_opts="nfsvers=3,port=%s,mountprog=%s,nfsprog=%s, >> udp,mountport=%s" >> % (nfsd_port, mountd_rpcport, nfsd_rpcport, mountd_port) >> + self.unfs_opts="nfsvers=3,port=%s,udp,mountport=%s" % >> (nfsd_port, >> mountd_port) >> >> # Extract .tar.bz2 or .tar.bz <http://tar.bz> if no nfs dir >> if not (self.rootfs and os.path.isdir(self.rootfs)): >> @@ -1006,7 +1002,7 @@ class BaseConfig(object): >> >> if self.fstype == 'nfs': >> self.rootfs_options = '' >> - k_root = '/dev/nfs nfsroot=%s:%s,%s' % (self.nfs_server, >> self.rootfs, self.unfs_opts) >> + k_root = '/dev/nfs nfsroot=%s:%s,%s' % (self.nfs_server, >> os.path.abspath(self.rootfs), self.unfs_opts) >> self.kernel_cmdline = 'root=%s rw highres=off' % k_root >> >> if self.fstype == 'none': >> -- >> 2.11.0 >> >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> <mailto:Openembedded-core@lists.openembedded.org> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> <http://lists.openembedded.org/mailman/listinfo/openembedded-core> >> >> >> >> >> -- >> "Thou shalt not follow the NULL pointer, for chaos and madness await thee >> at its >> end" >> > -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"
-- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
