Hi,
On Mon, Jun 19, 2017 at 11:32:38AM +0100, André Draszik wrote:
> From: André Draszik <adras...@tycoint.com>
>
> When building with nftables support, connman doesn't ever
> depend on the nftables command line tool.
>
> connman will depend on libmnl and libnftnl at build and
> run time. In addition, the nftables rules it creates
> depend on various kernel modules being present.
>
> Update the PACKAGECONFIG to reflect this.
>
> Signed-off-by: André Draszik <adras...@tycoint.com>
> Acked-by: Sylvain Lemieux <slemi...@tycoint.com>
> ---
> meta/recipes-connectivity/connman/connman.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/connman/connman.inc
> b/meta/recipes-connectivity/connman/connman.inc
> index ab18f2fe01..132a58ff40 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -51,7 +51,7 @@ PACKAGECONFIG[l2tp] = "--enable-l2tp
> --with-l2tp=${sbindir}/xl2tpd,--disable-l2t
> PACKAGECONFIG[pptp] = "--enable-pptp
> --with-pptp=${sbindir}/pptp,--disable-pptp,,pptp-linux"
> # WISPr support for logging into hotspots, requires TLS
> PACKAGECONFIG[wispr] = "--enable-wispr,--disable-wispr,gnutls,"
> -PACKAGECONFIG[nftables] = "--with-firewall=nftables ,,nftables,nftables"
> +PACKAGECONFIG[nftables] = "--with-firewall=nftables ,,libmnl
> libnftnl,kernel-module-nf-tables-ipv4 kernel-module-nft-chain-nat-ipv4
> kernel-module-nft-chain-route-ipv4 kernel-module-nft-meta
> kernel-module-nft-masq-ipv4 kernel-module-nft-nat"
> PACKAGECONFIG[iptables] = "--with-firewall=iptables ,,iptables,iptables"
Thanks for fixing this. However, this patch introduces some warnings:
WARNING: connman-1.34-r0 do_package_qa: QA Issue: connman rdepends on
kernel-module-nf-tables-ipv4, but it isn't a build dependency? [build-deps]
WARNING: connman-1.34-r0 do_package_qa: QA Issue: connman rdepends on
kernel-module-nft-chain-nat-ipv4, but it isn't a build dependency? [build-deps]
WARNING: connman-1.34-r0 do_package_qa: QA Issue: connman rdepends on
kernel-module-nft-chain-route-ipv4, but it isn't a build dependency?
[build-deps]
WARNING: connman-1.34-r0 do_package_qa: QA Issue: connman rdepends on
kernel-module-nft-masq-ipv4, but it isn't a build dependency? [build-deps]
WARNING: connman-1.34-r0 do_package_qa: QA Issue: connman rdepends on
kernel-module-nft-meta, but it isn't a build dependency? [build-deps]
WARNING: connman-1.34-r0 do_package_qa: QA Issue: connman rdepends on
kernel-module-nft-nat, but it isn't a build dependency? [build-deps]
NOTE: Tasks Summary: Attempted 2032 tasks of which 2000 didn't need to be rerun
and all succeeded.
Please consider fixing this as well.
Best Regards,
Maxin
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
