On Thu, Jun 15, 2017 at 1:05 AM,  <yin.thong.cho...@intel.com> wrote:
> From: Choong YinThong <yin.thong.cho...@intel.com>
>
> Added default argument for ubi and ubifs image creation.

Hello,

Is it better to error out *before* ot to create an *invalid* image?
How can you guess such defaults?

Cheers
Andrea



> MKUBIFS_ARGS and UBINIZE_ARGS both argument still able to
> edit in local.conf
>
> [YOCTO #11589]
>
> Signed-off-by: Choong YinThong <yin.thong.cho...@intel.com>
> ---
>  meta/classes/image_types.bbclass | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/meta/classes/image_types.bbclass 
> b/meta/classes/image_types.bbclass
> index 7749b00..bbde08d 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -292,3 +292,12 @@ IMAGE_EXTENSION_live = "hddimg iso"
>  # The IMAGE_TYPES_MASKED variable will be used to mask out from the 
> IMAGE_FSTYPES,
>  # images that will not be built at do_rootfs time: vmdk, vdi, qcow2, 
> hdddirect, hddimg, iso, etc.
>  IMAGE_TYPES_MASKED ?= ""
> +
> +# Default argument to create ubi and ubifs image with core-image-sato-sdk 
> (http://www.linux-mtd.infradead.org/faq/ubifs.html)
> +# -m 2048: tells mkfs.ubifs that the minimum input/output unit size of the 
> flash this UBIFS image is created for is 2048 bytes (NAND page in this case);
> +# -e 129024: logical eraseblock size of the UBI volume this image is created 
> for;
> +# -c 8749: specifies maximum file-system size in logical eraseblocks; this 
> means that it will be possible to use the resulting file-system on volumes up 
> to this size (less or equivalent); so in this particular case, the resulting 
> FS may be put on volumes up to about 251MiB (129024 multiplied by 2047); See 
> this section for more details.
> +# -p 128KiB: tells ubinize that physical eraseblock size of the flash chip 
> the UBI image is created for is 128KiB (128 * 1024 bytes);
> +# -s 512: tells ubinize that the flash supports sub-pages and sub-page size 
> is 512 bytes; ubinize will take this into account and put the VID header to 
> the same NAND page as the EC header.
> +MKUBIFS_ARGS ??= " -m 2048 -e 129024 -c 8749 "
> +UBINIZE_ARGS ??= " -p 128KiB -m 2048 -s 512 "
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to