On Wed, Nov 23, 2016 at 3:00 AM, Otavio Salvador < otavio.salva...@ossystems.com.br> wrote:
> On Thu, Nov 17, 2016 at 2:24 PM, Christopher Larson <clar...@kergoth.com> > wrote: > > > > On Thu, Nov 17, 2016 at 9:21 AM, Fabio Berton > > <fabio.ber...@ossystems.com.br> wrote: > >> > >> No, I created a patch, git format-patch and then edit generated files > with > >> Upstream-Status tag and added to recipe. Is this wrong? > > > > > > As I indicated in my first reply, it’s best to put the tag outside the > > generated patch (above it, or below the —-), as it isn’t part of the > commit, > > only part of the patch file. It’s minor, and you don’t need to re-submit, > > but in general the tag is not part of the commit message. For example, if > > your patch was applied to a git repository with git-am, it’d be in the > > commit message, which should not be the case. > > To be honest, there a many files which does as Fabio did and I also > personally do as well. I don't like it outside of the commit log as it > looks out of context. > > If someone is getting the patch file, it is expected they will review > it and not blindly apply it on upstream repository. I don’t feel too strongly about it, if that’s the consensus, that’s fine, I just wanted to open up a dialogue on the subject. Thanks. -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics
-- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
