On 28 Sep 2016, at 21:31, Robert Yang wrote:
Hi Peter,
Thanks for the reply, I tested your patch from git repo, it doesn't
work,
the message goes to the terminal:
Child process exit status 4: lock_held
Huh. I'll have to look more closely, then.
$ kill -9 `ps aux | grep /usr/bin/pseud | awk '{print $2}'` ;
/buildarea/lyang1/test_gen/tmp/sysroots/x86_64-linux/usr/bin/pseudo &
/buildarea/lyang1/test_gen/tmp/sysroots/x86_64-linux/usr/bin/pseudo
Hmm.
If there are gigabytes log messages, will 8 characters prefix "pseudo:
"
contributes a lot to that?
If we've got logging on enough to produce a lot, then it'll be a bit.
And there isn't any reason to prefix *all* the messages. The only reason
these mattered is that they show up in the middle of a build without
context. If we take away the very small number of messages that were
showing up on the console (which should probably be pseudo_debug()
messages
now anyway), there's no need for the prefixing.
pseudo_diag() is sometimes used to produce partial lines. So
pseudo_diag("foo: ");
pseudo_diag("bar\n");
Should pseudo_diag() be used in this way ? I think no according to
other log
utils such as python's logging module.
This is not other log utils. This logging utility *specifically* allows
for partial
lines, and has extra support for them.
I'll have a look at the diagnostics now that we have that nice quick
reproducer.
-s
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
