On 06/16/2016 05:45 PM, Christopher Larson wrote:
Thanks for the contribution, though, it's appreciated. Perhaps someone
else can comment on the patch itself.
The idea behind the fix is correct (latest cmake seems to have its
modules in /usr/share/cmake-<version>/Modules rather than
/usr/share/cmake/Modules), but the patch is wrong in multiple ways:
1) needs to be rebased against latest master, the line it's patching has
been changed over a year ago actually.
2) the patch is only adding another patch :) This extra layer needs to go.
3) the commit message should contain a single, short sentence in the
first paragraph that explains what the patch is doing:
"cmake.bbclass: set the modules directory correctly"
Then the rest of the commit message should explain why that needs to
happen and also can go into further details of how the problem is fixed.
Alex
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
