On Tue, May 03, 2016 at 07:33:58PM +0000, Christopher Larson wrote: > On Tue, May 3, 2016 at 7:31 PM, Christopher Larson <clar...@kergoth.com> > wrote: > > > > > > > On Mon, May 2, 2016 at 12:22 PM, Ed Bartosh <ed.bart...@linux.intel.com> > > wrote: > > > >> Generated standalone bmaptool script that is more convenient > >> to use than native script. It can be run straight from > >> its location ./tmp/deploy/tools/bmaptool. The script doesn't > >> depend on anything except Python. > >> > >> Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> > >> > > > > You're right that this is very handy, but we hit a problem when building > > from shared state. This uses do_deploy to deploy bmaptool into > > DEPLOY_DIR_IMAGE, but IMAGE_DEPENDS only depends on do_populate_sysroot, > > not do_deploy, so an image build from sstate won't write this script out. > > > > I don't know the right way to fix this, but it's a problem. I just ran > > into it :) > > > > Also, the convention is to add do_deploy before do_build, not before > do_package, otherwise do_deploy's checksum is included int he checksums of > do_package and subsequent tasks, even though its output isn't used by any > subsequent tasks.
I also found this a bit unusual to put the tool into deploy/tools. That's why I isolated this change. I think it requires some more testing, but the rest of patchset can be accepted without it. -- Regards, Ed -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
