On 03/21/2016 10:47 PM, Burton, Ross wrote:
On 19 March 2016 at 14:56, Hongxu Jia <hongxu....@windriver.com
<mailto:hongxu....@windriver.com>> wrote:
+PACKAGECONFIG[debug] = "--enable-debug=yes, --enable-debug=no"
There's an explicit --enable-debug in EXTRA_OECONF,
Yes, we should remove the duplicated --enable-debug in EXTRA_OECONF
and reading the configure --help shows that the "off" mode should be
--enable-debug=minimum as "no" removes the GLib checks which can
result in crashes if bad data is passed to the API.
./configure --help
...
--enable-debug Compile with debug checks. [no/yes/minimum,
default=minimum]
...
vim ./configure.ac
...
121 dnl Default to debug spew in unstable branch
122 AC_ARG_ENABLE(debug,
123 AS_HELP_STRING([--enable-debug],
124 [Compile with debug checks. @<:@no/yes/minimum,
default=minimum@:>@]),
125 , enable_debug=minimum)
126
127 if test "x$enable_debug" = "xyes"; then
128 CFLAGS="$CFLAGS -DGCONF_ENABLE_DEBUG=1"
129 AC_MSG_NOTICE([Will build with debugging spew and checks])
130 else
131 if test "x$enable_debug" = "xno"; then
132 CFLAGS="$CFLAGS -DG_DISABLE_CHECKS=1 -DG_DISABLE_ASSERT=1"
133 AC_MSG_NOTICE([Will build without *any* debugging code])
134 else
135 AC_MSG_NOTICE([Will build with debug checks but no debug spew])
136 fi
137 fi
...
vim gconf/gconfd.c
...
384 #ifdef GCONF_ENABLE_DEBUG
385 /* -- Debug only */
386
387 if (addresses == NULL)
388 {
389 gconf_log(GCL_DEBUG, _("gconfd compiled with debugging;
trying to load gconf.path from the source directory"));
390 conffile = g_strconcat(GCONF_SRCDIR, "/gconf/gconf.path", NULL);
391 addresses = gconf_load_source_path(conffile, NULL);
392 g_free(conffile);
393 }
394
395 /* -- End of Debug Only */
396 #endif
...
If we could not use '--enable-debug=yes' to fix build paths issue,
and as your suggested it should not remove check and assert,
so minimum is the best choice.
//Hongxu
Ross
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
