Hmmm… It seems the subject line was cut… It was supposed to say "system: binfmt should be added to SYSTEMD_PACKAGES only if binfmt is enabled". Yep, the second condition was overkill, I agree. I'll send a new version of the patch.
Thanks, Herve From: Burton, Ross [mailto:ross.bur...@intel.com] Sent: lundi 7 mars 2016 15:39 To: Herve Jourdain <herve.jourd...@neuf.fr> Cc: OE-core <openembedded-core@lists.openembedded.org> Subject: Re: [OE-core] [meta-oe][PATCH] systemd: binfmt should be added to SYSTEMD_PACKAGES First, the commit message isn't accurate (binfmt was already in SYSTEMD_PACKAGES). On 7 March 2016 at 14:17, Herve Jourdain <herve.jourd...@neuf.fr> wrote: -SYSTEMD_PACKAGES = "${PN}-binfmt" -SYSTEMD_SERVICE_${PN}-binfmt = "systemd-binfmt.service" +SYSTEMD_PACKAGES = "${@bb.utils.contains('PACKAGECONFIG', 'binfmt', '${PN}-binfmt', '', d)}" +SYSTEMD_SERVICE_${PN}-binfmt = "${@bb.utils.contains('PACKAGECONFIG', 'binfmt', 'systemd-binfmt.service', '', d)}" You don't need to conditionalise SYSTEDM_SERVICE_${PN}-binfmt, just SYSTEMD_PACKAGES. Ross -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
