2016-02-23 12:36 skrev Markus Lehtonen:
> It would seem reasonable
that do_unpack() always results in a pristine source
> tree. This patch
causes ${S} to be removed before unpacking sources.
>
> I didn't quite
understand what kind of "investigation" the following code
> comment in
do_unpack() was referring to:
> # TODO: Investigate if we can remove
> #
the entire ${S} in this case.
> What kind of special cases might we
have? At least qemux86 core-image-sato
> builds fine for me.
The text
isn't referring to any investigation already done. But me and Paul
Eggleton discussed this matter (removing entire ${S}, not just
{$S}/patches) within the scope of another bug. But since this wasn't
really the scope for that bug, the TODO was added instead. And happily
you have done the investigation and it's seems like ${S} might be able
to be removed in this case, after all :)
So please go ahead and you can
remove that TODO comment within the scope of this patch, since if this
change gets merged it's not relevant anymore..
BR Petter
> [YOCTO
#9064] Markus Lehtonen (1): base.bbclass wipe ${S} before unpacking
source meta/classes/base.bbclass | 8 +++----- 1 file changed, 3
insertions(+), 5 deletions(-) -- 2.6.2
See inline comments.
Petter
Mabäcker
Technux <pet...@technux.se>
www.technux.se
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
