Hi Paco, good to see you doing patches.
Please check my comments below.
On Mon, 2016-02-15 at 13:10 -0600, Francisco Pedraza wrote:
> When stopping the prserver using localhost as host, it tries to
> find a file '/tmp/PRServer_127.0.0.1_8585.pid' which is not
> present on the system.
>
> fix for [YOCTO #8258]
>
> Signed-off-by: Francisco Pedraza <
> francisco.j.pedraza.gonza...@intel.com>
> ---
> meta/lib/oeqa/selftest/prservice.py | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/meta/lib/oeqa/selftest/prservice.py
> b/meta/lib/oeqa/selftest/prservice.py
> index f22288e..fbde5a6 100644
> --- a/meta/lib/oeqa/selftest/prservice.py
> +++ b/meta/lib/oeqa/selftest/prservice.py
> @@ -9,9 +9,9 @@ import oeqa.utils.ftools as ftools
> from oeqa.selftest.base import oeSelfTest
> from oeqa.utils.commands import runCmd, bitbake, get_bb_var
> from oeqa.utils.decorators import testcase
> +from oeqa.utils.network import get_free_port
>
> class BitbakePrTests(oeSelfTest):
> -
seems like a line delete slipped here above
> def get_pr_version(self, package_name):
> pkgdata_dir = get_bb_var('PKGDATA_DIR')
> package_data_file = os.path.join(pkgdata_dir, 'runtime',
> package_name)
> @@ -119,3 +119,16 @@ class BitbakePrTests(oeSelfTest):
> @testcase(936)
> def test_pr_service_ipk_arch_indep(self):
> self.run_test_pr_service('xcursor-transparent-theme', 'ipk',
> 'do_package')
> +
> + @testcase(1419)
> + def test_stopping_prservice_message(self):
> + output_msg_passed = 'Waiting for pr-server to exit.'
> + err_msg = 'pidfile /tmp/PRServer_localhost_8585.pid does not
> exist. Daemon not running?'
while it is good to check for known error conditions, this one seems
very specific and could mutate easily. I.e. if the pidfile has a
different PID, the error message will not be the same as the one you
describe. This is better checked via a search expression.
> +
> + port = get_free_port()
> + runCmd('bitbake-prserv --host localhost --port %s -
> -loglevel=DEBUG --start' % port)
> + ret = runCmd('bitbake-prserv --host localhost --port %s -
> -loglevel=DEBUG --stop' % port)
> +
> + self.assertNotEqual(ret.output, err_msg)
You're checking the expected message first, that makes this second
check below for the unexpected message to be highly unlikely to happen
at this point.
I believe that checking just for the expected message would account for
the objective of the test.
> + self.assertEqual(ret.output, output_msg_passed)
> +
> --
> 2.5.0
>
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
