On Fri, 2016-01-29 at 18:36 -0800, Khem Raj wrote: > > On Jan 29, 2016, at 5:25 PM, Hongxu Jia <hongxu....@windriver.com> > > wrote: > > > > On 01/30/2016 01:47 AM, Peter Kjellerstedt wrote: > > > Wouldn't it be better to swap the first and second commit and > > > then > > > move the addition of -gno-record-debug-prefix-map to the other > > > commit > > > where -fdebug-prefix-map are added. > > > > OK > > > > > > > > You must also remember that not all use the compiler provided by > > > OE-Core, so adding -gno-record-debug-prefix-map unconditionally > > > to > > > DEBUG_CFLAGS will break with unpatched compilers... (This also > > > indicates that "Upstream-Status: Inappropriate [oe specific]" may > > > not be quite right if you want this to be supported by other > > > compiler versions). > > > > Agree, we should conditionally add -gno-record-debug-prefix-map to > > support other compiler. Thank you for pointing it out. > > its not only non gcc compilers, we also have gcc 4.9 still.
I think we do likely need to patch 4.9. For other compilers than that, or other compilers, I'd suggest that people can either define a set of DEBUG_CFLAGS, or set: DEBUG_CFLAGS_remove = "-gno-record-debug-prefix-map" to avoid problems. I'm not sure making it conditional in some way is any better than just using the above line. Cheers, Richard -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
