On 29 January 2016 at 12:22, Ioan-Adrian Ratiu <adrian.ra...@ni.com> wrote:
> +PACKAGECONFIG_append = " ldap crypto sqlite3"
>
Never use PACKAGECONFIG_append in a recipe as then they can't easily be
disabled. Recipes should use PACAKGECONFIG??="options".
apr is used by more than just apache, and the need for LDAP and sqlite
isn't universal. I think these should default to disabled and the the
user/distro/whatever can enable them if required.
> +PACKAGECONFIG[ldap] = "--with-ldap,,openldap,"
>
You need a --without-ldap here.
> +PACKAGECONFIG[crypto] = "--with-crypto,,,"
>
Dito.
> +PACKAGECONFIG[sqlite3] = "--with-sqlite3=${STAGING_DIR_HOST}${prefix},,,"
>
Ditto.
Also, there's no point adding extra trailing commas, they just look ugly.
> +FILES_${PN} += "${libdir}/apr-util-1/apr_ldap-1.so"
> +FILES_${PN}-dev += "${libdir}/apr-util-1/apr_ldap.so*
> ${libdir}/apr-util-1/apr_ldap.la"
> +FILES_${PN}-staticdev += "${libdir}/apr-util-1/apr_ldap.a"
> +
> +FILES_${PN} += "${libdir}/apr-util-1/apr_crypto_openssl-1.so"
> +FILES_${PN}-dev += "${libdir}/apr-util-1/apr_crypto_openssl.so*
> ${libdir}/apr-util-1/apr_crypto_openssl.la"
> +FILES_${PN}-staticdev += "${libdir}/apr-util-1/apr_crypto_openssl.a"
> +
> +FILES_${PN} += "${libdir}/apr-util-1/apr_dbd_sqlite3-1.so"
> +FILES_${PN}-dev += "${libdir}/apr-util-1/apr_dbd_sqlite3.so*
> ${libdir}/apr-util-1/apr_dbd_sqlite3.la"
> +FILES_${PN}-staticdev += "${libdir}/apr-util-1/apr_dbd_sqlite3.a"
> +
> FILES_${PN} += "${libdir}/apr-util-1/apr_dbm_gdbm-1.so"
> FILES_${PN}-dev += "${libdir}/aprutil.exp
> ${libdir}/apr-util-1/apr_dbm_gdbm.so* ${libdir}/apr-util-1/apr_dbm_gdbm.la
> "
> FILES_${PN}-staticdev += "${libdir}/apr-util-1/apr_dbm_gdbm.a"
>
Please change the existing FILES_ to use globs instead of listing all the
files to match explicitly.
Ross
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
