On Fri, Jan 22, 2016 at 11:36:44PM +0000, Burton, Ross wrote:
> On 22 January 2016 at 23:25, <bmour...@ni.com> wrote:
>
> > > Can you add this to the SRC_URI assignment in avahi.inc please.
> >
> > I did this initially, but considering that the next version of avahi will
> > include this change, I didn't think that was the best approach. I'm fine
> > with including it there, but it didn't seem right to me. Convince me
> > that it's the correct place to put the change.
>
>
> Mainly for consistency: all the other patches are listed in the SRC_URI in
> avahi.inc.
>
> Another good reason is that it ensures that both avahi and avahi-ui get
> built with the same source.
Good enough reasoning for me. As I noted, I was on the fence anyway. Comment
to that effect in the recipe, simply leave it to the commit message, or
some exotic ${bb shell} conditional include?
I'll submit v2 on Monday. Thanks for the feedback.
> Ross
--
Brad Mouring
Senior Software Engineer
National Instruments
512-683-6610 / bmour...@ni.com
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
