On Wed, Jan 13, 2016 at 8:09 PM, Tom Rini <tr...@konsulko.com> wrote:
> On Wed, Jan 13, 2016 at 01:55:56PM -0200, Otavio Salvador wrote:
>> On Wed, Jan 13, 2016 at 1:53 PM, Marek Vasut <ma...@denx.de> wrote:
>> > On Wednesday, January 13, 2016 at 04:39:53 PM, Otavio Salvador wrote:
>> >> On Wed, Jan 13, 2016 at 12:34 PM, Marek Vasut <ma...@denx.de> wrote:
>> >> > On Wednesday, January 13, 2016 at 01:04:31 PM, Otavio Salvador wrote:
>> >> >> On Wed, Jan 13, 2016 at 1:36 AM, Marek Vasut <ma...@denx.de> wrote:
>> >> >> > Upgrade U-Boot to latest version and drop upstreamed patches.
>> >> >> >
>> >> >> > Repair configuration of U-Boot during build. It is no longer
>> >> >> > possible to run "make foomachine" in U-Boot. Instead, it is
>> >> >> > necessary to do "make foomachine_defconfig ; make". Fix this
>> >> >> > in u-boot.inc and u-boot-fw-utils*.bb .
>> >> >>
>> >> >> Please drop this config suffix, from u-boot.inc. The config value
>> >> >> should be used as is and the respective BSP ought to be fixed to
>> >> >> change _config to _defconfig.
>> >> >
>> >> > If I don't have the _defconfig there AND I define UBOOT_MACHINE in my
>> >> > machine file, it will call "make machine", which no longer works.
>> >>
>> >> I know and the right fix is to use the right value to UBOOT_MACHINE as
>> >> we do for KERNEL_DEVICETREE.
>> >
>> > So what is the right value ? UBOOT_MACHINE := "foo_defconfig" ? This does
>> > not sound right at all.
>> >
>> > And what is the right value of UBOOT_CONFIG then ?
>>
>> foo_defconfig.
>>
>> This is what we pass for make to configure the board and should be the
>> given value.
>>
>> As we does for device tree, where we pass for KERNEL_DEVICETREE:
>>
>> foo-bar.dtb
>>
>> and this is also given for the make, for the kernel.
>
> This is not the same thing in my view. In the kernel you're also
> getting that as the output file.
>
> What we should do, and I've wanted to do for ages but always never get
> around to it is:
>
> do_configure() {
> oe_runmake ${UBOOT_MACHINE}_config
> }
>
> do_compile() {
> oe_runmake
> }
>
> As _config has worked for forever. And modify the above as-needed for
> the env recipes and so forth.
Any change like this need to be proposed as another patch; please
split this patch in upgrade and logic change. So we review and test
them separated.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
