Hi Anibal, Please see my comments inline. Regards, Tudor.
On 04/01/2016 20:29, Aníbal Limón wrote: > The whole set is sent to two ML for reviewing purposes the first > two patches are for oe-core and the last one for poky. > > The first two commits (oe-core) adds a new ptest-runner written in > python the sh one is conserved to use in tiny systems. > > What's new in ptest runner: > > - Monitor/timeout stdout, stderr of the test suite to avoid block > indefinetly. This is definitely something useful. > - Add option for change ptest root directory. - Add option for list > available tests. - Add option for only run certain tests. > > The last commit (meta-yocto) sets ptest-runner to 1.0 in poky-tiny > systems due to python dependency. I think adding python dependency is a shift in a wrong direction for for ptest-runner. The assumption that most embedded devices (tiny or not) have python might not be correct. The alternative of using the old version of ptest-runner only complicate things. I do think this kind of work is really useful but this should be done into a testing framework that runs outside of the DUT. > > The changes are available in the git repository at: > > git://git.yoctoproject.org/poky-contrib alimon/ptest-runner > http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=alimon/ptest-runner > > Aníbal Limón (3): ptest-runner: Add version 2.0 re-implementation > in python. ptest-runner: Add a recipe for install ptest-runner > 2.0. conf/distro/poky-tiny.conf: Add default install of > ptest-runner 1.0 > > meta-yocto/conf/distro/poky-tiny.conf | 4 + > .../ptest-runner/files/ptest-runner_2.0.py | 162 > +++++++++++++++++++++ .../ptest-runner/ptest-runner_2.0.bb > | 27 ++++ 3 files changed, 193 insertions(+) create mode 100755 > meta/recipes-support/ptest-runner/files/ptest-runner_2.0.py create > mode 100644 meta/recipes-support/ptest-runner/ptest-runner_2.0.bb > -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
