Hello Bruce, On Sat, Dec 19, 2015 at 3:44 PM, Bruce Ashfield <bruce.ashfi...@gmail.com> wrote: > On Sat, Dec 19, 2015 at 5:05 AM, Otavio Salvador > <otavio.salva...@ossystems.com.br> wrote: >> >> On Fri, Dec 18, 2015 at 6:44 PM, Bruce Ashfield >> <bruce.ashfi...@windriver.com> wrote: >> > f4b27072 >> >> >> Use this revision on commit log; latest is not accurate as it moves during >> time. >> > > We'll disagree on that. The patch has the commit hash, repeating it in the > commit message is not necessary. It's like patches saying "this patch", or > explaining what is obvious from the patch. Both are not necessary. > > If Ross wants to change the commit during merge, I won't complain, but > I'm happy with it, as is.
Commit logs are suppose to have the information useful to understand the reason of the change. Latest hides all behind it and does not communicate anything. I don't think expect people to read the code to know you bumped (and to which) revision is right. I am not the OE-Core maintainer but for any layer I am, I require this to be recorded. >From me, this is a NACK! -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
