On 11/3/15 6:06 PM, Peter Kjellerstedt wrote:
> Read and merge the passwd/group files before parsing the user and
> group definitions. This means they will only be read once per
> recipe. This solves a problem where if a user was definied in multiple
> files, it could generate group definitions for groups that should not
> be created. E.g., if the first passwd file read defines a user as:
>
> foobar::1234::::
>
> and the second passwd file defines it as:
>
> foobar:::nogroup:The foobar user:/:/bin/sh
>
> then a foobar group would be created even if the user will use the
> nogroup as its primary group.
One minor thing
> @@ -251,7 +269,7 @@ def update_useradd_static_config(d):
>
> newparams.append(newparam)
>
> - return " ;".join(newparams).strip()
> + return ";".join(newparams).strip()
>
> # Load and process the users and groups, rewriting the adduser/addgroup
> params
> useradd_packages = d.getVar('USERADD_PACKAGES', True)
>
The space was required because you could generate a user/group add line that
ended with a string. Without the space, you could end up merging two sets of
arguments causing a failure condition.
So I think that it should be retained unless there is a specific reason you
believe it should be removed.
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
