On Tue, 2015-09-01 at 21:09 +0200, Martin Jansa wrote: > On Tue, Sep 01, 2015 at 10:45:22AM +0000, g...@git.openembedded.org wrote: > > Module: openembedded-core.git > > Branch: master > > Commit: 8236d57439640a185c0226312cd4903a3ce2f53b > > URL: > > http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=8236d57439640a185c0226312cd4903a3ce2f53b > > > > Author: Alex Franco <alejandro.fra...@linux.intel.com> > > Date: Fri Aug 28 17:34:04 2015 -0500 > > > > Fix mode +st on TMPDIR when creating it > > > > A sanity check fails when TMPDIR has setuid, setgid set. It was > > proposed to fix this on TMPDIR creation instead of failing with > > a sanity test only. This patch handles removal of those special > > bits (and additonally, the sticky bit) from BUILDDIR and TMPDIR > > when these directories are created. > > Can you explain why it's needed to remove them?
At least in theory the sticky bit (t) can end up influencing the target package file ownership. In the interests of build determinism we really need TMPDIR to start in a consistent way with a consistent set of permissions. Put another way, I don't really want to have to add new sanity tests that test if builds work the same if TMPDIR is +t compared to a dir that isn't set that way. So if you could tweak your autobuilder setup to lose the sticky bit on that directory, I think that would be preferable to adding more corner cases to the build environment. If everyone had setups like this, that would change my view but it doesn't seem to eb the ase. Cheers, Richard -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
