On Sun, Aug 30, 2015 at 09:22:50PM -0700, Christopher Larson wrote: > On Sun, Aug 30, 2015 at 2:14 PM, Ed Bartosh <ed.bart...@linux.intel.com> > wrote: > > > Write set of bitbake variables used by wic into > > build/tmp/sysroots/<machine>/imagedata/<image>.env > > > > List of variables is defined in WICVARS variable in > > meta/classes/image_types.bbclass. > > > > This is needed for wic to be able to get bitbake variables without > > running 'bitbake -e'. > > > > Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> > > > > The function name (_write_env) sounds generic, as does the commit message, > and the filename, yet it relies on a variable which is WIC-specific. This > seems rather inconsistent to me, either this thing is for wic alone, or it > isn't, and the function name, file name, and variable name should reflect > that.
Thanks for pointing this out. I'll rename _write_env to _write_wic_env it in the next patchset. -- Regards, Ed -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
