> On Aug 21, 2015, at 2:58 PM, Otavio Salvador > <otavio.salva...@ossystems.com.br> wrote: > > On Fri, Aug 21, 2015 at 6:49 PM, Khem Raj <raj.k...@gmail.com> wrote: >> >>> On Aug 21, 2015, at 2:38 PM, Otavio Salvador <ota...@ossystems.com.br> >>> wrote: >>> >>> The 'BRANCH' variable name has no explicit relation with the >>> SRC_URI. Using 'SRC_BRANCH' makes it more obvious and easier to >>> identify. >> >> Look good to me, just may be avoid ‘_’ and call it SRCBRANCH > > I did this initially but looking at how it looks in the source code, > it seems SRC_BRANCH makes easier to spot the relation with SRC_URI. So > I took the second.
since bitbake use ‘_’ as a override separator, its less confusing if variables don’t have underscore in them for future collision. > > -- > Otavio Salvador O.S. Systems > http://www.ossystems.com.br http://code.ossystems.com.br > Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
signature.asc
Description: Message signed with OpenPGP using GPGMail
-- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
