On Sat, 2015-08-08 at 12:48 -0700, Khem Raj wrote:
> > On Aug 7, 2015, at 7:28 AM, Alexander Kanavin
> > <alexander.kana...@linux.intel.com> wrote:
> >
> > Also, use tarballs instead of git for fetching source code.
> > git repository does not have version tags, so upstream version check
> > cannot be performed.
> >
> > Signed-off-by: Alexander Kanavin <alexander.kana...@linux.intel.com>
> > ---
> > .../recipes-devtools/fdisk/{gptfdisk_git.bb => gptfdisk_1.0.0.bb} | 8
> > +++-----
> > 1 file changed, 3 insertions(+), 5 deletions(-)
> > rename meta/recipes-devtools/fdisk/{gptfdisk_git.bb => gptfdisk_1.0.0.bb}
> > (75%)
> >
> > diff --git a/meta/recipes-devtools/fdisk/gptfdisk_git.bb
> > b/meta/recipes-devtools/fdisk/gptfdisk_1.0.0.bb
> > similarity index 75%
> > rename from meta/recipes-devtools/fdisk/gptfdisk_git.bb
> > rename to meta/recipes-devtools/fdisk/gptfdisk_1.0.0.bb
> > index 477c1d9..f4b0e32 100644
> > --- a/meta/recipes-devtools/fdisk/gptfdisk_git.bb
> > +++ b/meta/recipes-devtools/fdisk/gptfdisk_1.0.0.bb
> > @@ -5,11 +5,9 @@ LIC_FILES_CHKSUM =
> > "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"
> >
> > DEPENDS = "util-linux popt ncurses"
> >
> > -PV = "0.8.10+git${SRCPV}”
>
> its always preferable to have PV contain SRCPV for recipes using SCM based
> fetch mechanism. Don’t drop it
There has been discussion about this in other threads and the conclusion
reached is that where there is a specific version being selected, having
PV of that specific version is a good thing. With "1.0.0+gitXXX" its
unclear if its really 1.0.0 or not.
Cheers,
Richard
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
