How many of these patches are applied in the 1.5 releases of GStreamer? We can upgrade instead and a colleague is going to be looking at the upgrades tomorrow, so if several can be dropped then that will save time and effort.
Ross On 27 July 2015 at 17:44, Otavio Salvador <otavio.salva...@ossystems.com.br> wrote: > Hello, > > I am fine with the patch but it needs fixing. > > Check below. > > On Mon, Jul 27, 2015 at 8:26 AM, Yuqing Zhu <b54...@freescale.com> wrote: > > Use g_utf16_to_utf8() instead of g_convert to fix the issue that > > id3 tags utf16 charaters cannot be extreacted in id3demux when try > > to get the id3v2 tag such as TIT2, TALB etc. > > > > Signed-off-by: Yuqing Zhu <b54...@freescale.com> > > --- > > .../fix-id3demux-utf16-to-utf8-issue.patch | 54 > ++++++++++++++++++++++ > > .../gstreamer/gstreamer1.0-plugins-base_1.4.5.bb | 1 + > > 2 files changed, 55 insertions(+) > > create mode 100755 > meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/fix-id3demux-utf16-to-utf8-issue.patch > > > > diff --git > a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/fix-id3demux-utf16-to-utf8-issue.patch > b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/fix-id3demux-utf16-to-utf8-issue.patch > > new file mode 100755 > > index 0000000..458d153 > > --- /dev/null > > +++ > b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/fix-id3demux-utf16-to-utf8-issue.patch > > @@ -0,0 +1,54 @@ > > +Author: Lyon Wang <b12...@freescale.com> > > +Date: Thu Oct 9 17:37:43 2014 +0800 > > + > > +[id3v2frames] Bug fix for id3demux issue > > + > > +Fix the issue that id3 tags utf16 charaters cannot be extreacted in > id3demux > > +when I tried to get the id3v2 tag such as TIT2, TALB etc. it will > return extrac > > +failed. > > + > > +Checked in id3v2frame.c, When parse the UTF-16 streams, it used > g_convert() to > > +convert the buffer from UTF-16 to UTF-8, however it will return err > that this > > +conversion is not supported which cause the extraction failed with > these UTF-16 > > +characters. > > + > > +In the patch, use g_utf16_to_utf8() instead of g_convert, which can > convert the > > +character format successfully. > > + > > +https://bugzilla.gnome.org/show_bug.cgi?id=741144 > > + > > +Upstream Status: Pending > > It is: > > Upstream-Status: > > and it seems all patches you sent has this very same error. Please > update it and resend the whole serie (with this fixed in ALL patches) > as it is easy to get missed while applying the patches and makes > tracking harder. > > -- > Otavio Salvador O.S. Systems > http://www.ossystems.com.br http://code.ossystems.com.br > Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core >
-- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
