On Monday 20 July 2015 15:15:54 Christopher Larson wrote:
> From: Christopher Larson <chris_lar...@mentor.com>
>
> This makes it easier to extend, as a layer can add its own sub-commands.
>
> tinfoil is now passed into the commands, as we needed to parse the
> configuration metadata to get BBPATH, and we don't want to construct tinfoil
> more than once, otherwise we have to deal with startup and shutdown of
> cooker.
Hmm, but tinfoil is being constructed twice, right? I think what you've
implemented is correct (and the only way it can really work), but this comment
doesn't seem to match up with the actual changes.
> + tinfoil = setup_tinfoil(config_only=True)
> + for path in ([scripts_path] +
> + tinfoil.config_data.getVar('BBPATH', True).split(':')):
> + pluginpath = os.path.join(path, 'lib', 'devtool')
> + scriptutils.load_plugins(logger, plugins, pluginpath)
> + tinfoil.cooker.shutdown(force=True)
> + tinfoil.cooker.unlockBitbake()
FYI I think Richard is about to add a shutdown method to tinfoil itself that
will do what's needed here; however we can tidy this up after that's added.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
