On Thu, Dec 11, 2014 at 1:34 AM, b40...@freescale.com
<b40...@freescale.com> wrote:
> Hello Otavio,
> Sorry for my late reply.
> Thanks for your review .
> I have submitted v4 of the patchest.
>
...
Comments below...
>> if [ "x${UBOOT_ENV}" != "x" ]
>> then
>> @@ -93,21 +100,36 @@ do_install () {
>> FILES_${PN} = "/boot ${sysconfdir}"
>>
>> do_deploy () {
>> - install -d ${DEPLOYDIR}
>> - install ${S}/${UBOOT_BINARY} ${DEPLOYDIR}/${UBOOT_IMAGE}
>> -
>> - cd ${DEPLOYDIR}
>> - rm -f ${UBOOT_BINARY} ${UBOOT_SYMLINK}
>> - ln -sf ${UBOOT_IMAGE} ${UBOOT_SYMLINK}
>> - ln -sf ${UBOOT_IMAGE} ${UBOOT_BINARY}
>> -
>> - if [ "x${SPL_BINARY}" != "x" ]
>> - then
>> - install ${S}/${SPL_BINARY} ${DEPLOYDIR}/${SPL_IMAGE}
>> - rm -f ${DEPLOYDIR}/${SPL_BINARY} ${DEPLOYDIR}/${SPL_SYMLINK}
>> - ln -sf ${SPL_IMAGE} ${DEPLOYDIR}/${SPL_BINARY}
>> - ln -sf ${SPL_IMAGE} ${DEPLOYDIR}/${SPL_SYMLINK}
>> - fi
>> + for type in ${UBOOT_MACHINE}; do
>> + for imagetype in in ${UBOOT_CONFIG}; do
>> + if [ "${imagetype}"x = "in"x ]
>> + then
>> + continue
>> + fi
>> + if [ -d "${DEPLOYDIR}/u-boot-${imagetype}.${UBOOT_SUFFIX}"]
>> + then
>> + break
>> + else
>> + install -d ${DEPLOYDIR}
>> + install ${S}/${type}/u-boot-${type}.${UBOOT_SUFFIX}
>> ${DEPLOYDIR}/u-boot-${imagetype}.${UBOOT_SUFFIX}
>> + if [ "${imagetype}"x = "sd"x ] || [ "${imagetype}"x =
>> "mfgtool"x ]
>> + then
>> + cp ${DEPLOYDIR}/u-boot-${imagetype}.${UBOOT_SUFFIX}
>> ${DEPLOYDIR}/u-boot-${MACHINE}.${UBOOT_SUFFIX}
>> + fi
>> + fi
>
> Way nicer (and should have some similar code on the install and compile
> tasks) however I didn't get why you're adding the 'sd' or 'mfgtool' specific
> case here. This is a FSL specific thing and shouldn't be part of OE-Core.
>
> [ I use default link of last type uboot of "UBOOT_CONFIG" to fix the
> following error:
>
> * difficulty to figure the binary when generating the rootfs: in
> meta-fsl-arm, for example, we generate the .sdcard rootfs and using the patch
> we now have...
>
> ERROR: Error: The image creation script
> '.../tmp/work/imx6qsabresd-oel-linux-gnueabi/core-image-minimal/1.0-r0/temp/create_image.sdcard'
>
> ]
Right I am wondering if we ought to do this or not. This is a FSL
specific code and I will try to think in a way to improve it at
meta-fsl-arm side ...
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
