On 10/11/2014 06:17 PM, Hongxu Jia wrote:
On 10/11/2014 05:31 PM, Paul Barker wrote:
Your solution looks fine but I'd prefer it to be solved a different
way upstream.
It should be possible to ensure that duplicates don't enter the
removal queue in the first place by checking the return of
pkg_vec_contains(dependent_pkgs, dep_pkg) before calling
pkg_vec_insert(dependent_pkgs, dep_pkg) in opkg_remove_dependent_pkgs.
This would keep the logic in opkg_remove_pkg clean.
The pkg_vec_contains(dependent_pkgs, dep_pkg) could not work here.
Because 'dependent_pkgs' is not global which contains all removed pkgs.
The checking will filter duplicated pkg.
s/will/will not/
//Hongxu
//Hongxu
If you've got time to try this alternative solution could you let me
know if it works. If so, send the patch toopkg-de...@googlegroups.com
and I'll merge it upstream. If you're too busy I can have a look at
this myself next week.
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
