On Tuesday, September 23, 2014, <ting....@freescale.com> wrote: > From: Ting Liu <ting....@freescale.com <javascript:;>> > > none/tests/ppc64/Makefile.am (and ppc32, too) passes the flag -maltivec > unconditionally. Build will fail if Altivec not supported. add the flag > only if HAS_ALTIVEC defined. > > Why would you use altivec abi without altivec being found. Cover that in checks too please
> Reference: > see https://bugs.kde.org/show_bug.cgi?id=338731 > > Signed-off-by: Ting Liu <ting....@freescale.com <javascript:;>> > --- > .../pass-maltivec-only-if-it-supported.patch | 68 > ++++++++++++++++++++++ > meta/recipes-devtools/valgrind/valgrind_3.9.0.bb | 1 + > 2 files changed, 69 insertions(+) > create mode 100644 > meta/recipes-devtools/valgrind/valgrind/pass-maltivec-only-if-it-supported.patch > > diff --git > a/meta/recipes-devtools/valgrind/valgrind/pass-maltivec-only-if-it-supported.patch > b/meta/recipes-devtools/valgrind/valgrind/pass-maltivec-only-if-it-supported.patch > new file mode 100644 > index 0000000..3781466 > --- /dev/null > +++ > b/meta/recipes-devtools/valgrind/valgrind/pass-maltivec-only-if-it-supported.patch > @@ -0,0 +1,68 @@ > +Upstream-status: pending > + > +pass -maltivec only if it supported > + > +none/tests/ppc64/Makefile.am (and ppc32, too) passes the flag -maltivec > +unconditionally. Build will fail if Altivec not supported. add the flag > +only if HAS_ALTIVEC defined. > + > +Reference: > +see https://bugs.kde.org/show_bug.cgi?id=338731 > + > +Index: none/tests/ppc32/Makefile.am > +=================================================================== > +--- a/none/tests/ppc32/Makefile.am (revision 14477) > ++++ b/none/tests/ppc32/Makefile.am (working copy) > +@@ -72,8 +72,10 @@ > + allexec_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_NONNULL@ > + > + if HAS_ALTIVEC > ++BUILD_FLAG_ALTIVEC = -maltivec > + ALTIVEC_FLAG = -DHAS_ALTIVEC > + else > ++BUILD_FLAG_ALTIVEC = > + ALTIVEC_FLAG = > + endif > + > +@@ -101,11 +103,11 @@ > + ISA_2_07_FLAG = > + endif > + > +-jm_insns_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames -maltivec > \ > +- @FLAG_M32@ $(ALTIVEC_FLAG) > ++jm_insns_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames \ > ++ @FLAG_M32@ $(ALTIVEC_FLAG) $(BUILD_FLAG_ALTIVEC) > + > +-testVMX_CFLAGS = $(AM_CFLAGS) -O -g -Wall -maltivec -mabi=altivec > -DALTIVEC \ > +- -DGCC_COMPILER @FLAG_M32@ > ++testVMX_CFLAGS = $(AM_CFLAGS) -O -g -Wall -mabi=altivec -DALTIVEC \ > ++ -DGCC_COMPILER @FLAG_M32@ $(BUILD_FLAG_ALTIVEC) > + > + test_isa_2_06_part1_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g > -mregnames $(VSX_FLAG) \ > + @FLAG_M32@ $(ALTIVEC_FLAG) $(BUILD_FLAG_VSX) > +Index: none/tests/ppc64/Makefile.am > +=================================================================== > +--- a/none/tests/ppc64/Makefile.am (revision 14477) > ++++ b/none/tests/ppc64/Makefile.am (working copy) > +@@ -50,8 +50,10 @@ > + allexec_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_NONNULL@ > + > + if HAS_ALTIVEC > ++BUILD_FLAG_ALTIVEC = -maltivec > + ALTIVEC_FLAG = -DHAS_ALTIVEC > + else > ++BUILD_FLAG_ALTIVEC = > + ALTIVEC_FLAG = > + endif > + > +@@ -88,8 +90,8 @@ > + test_isa_2_06_part3_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g > -mregnames $(VSX_FLAG) \ > + @FLAG_M64@ $(ALTIVEC_FLAG) $(BUILD_FLAG_VSX) > + > +-jm_insns_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames -maltivec > \ > +- @FLAG_M64@ $(ALTIVEC_FLAG) > ++jm_insns_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames \ > ++ @FLAG_M64@ $(ALTIVEC_FLAG) $(BUILD_FLAG_ALTIVEC) > + > + test_dfp1_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames > $(DFP_FLAG) \ > + @FLAG_M64@ $(BUILD_FLAGS_DFP) > diff --git a/meta/recipes-devtools/valgrind/valgrind_3.9.0.bb > b/meta/recipes-devtools/valgrind/valgrind_3.9.0.bb > index c415e77..58bb9eb 100644 > --- a/meta/recipes-devtools/valgrind/valgrind_3.9.0.bb > +++ b/meta/recipes-devtools/valgrind/valgrind_3.9.0.bb > @@ -19,6 +19,7 @@ SRC_URI = " > http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \ > file://force-nostabs.patch \ > file://remove-arm-variant-specific.patch \ > file://remove-ppc-tests-failing-build.patch \ > + file://pass-maltivec-only-if-it-supported.patch \ > file://add-ptest.patch \ > file://run-ptest \ > " > -- > 1.8.3.2 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org <javascript:;> > http://lists.openembedded.org/mailman/listinfo/openembedded-core >
-- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
