On 09/18/2014 09:47 PM, Richard Purdie wrote:
I'm afraid I'm starting to feel very strongly this is not a direction we should move in. Having the ability to write out a .inc file containing on a delta is one thing, writing out a file for automatic inclusion and trying to maintain that file is not something I feel comfortable with.
Yes, I understand that your worry is reasonable, so many unexpected exception needs to be maintained
I think that at some point there needs to be external tooling handling the inclusion and updating of this file and that the sigs code is not the place for this.
I once coded a python script to handling the locked sig file from an existed sstate, translated sstate item name (ends with '.tgz.siginfo') to "<pn>:<task>:<hash>" tuple. The main blocker is: for some tasks (such as do_patch/do_fetch/ do_unpack), the target and native have the same pn in sstate, such as: ''sstate-cache/c6/sstate:automake::1.14.1:r0::3:c667b87f5d4e15198afc744f525895fc_unpack.tgz.siginfo" is used for "automake" and "automake-native", you could not figure out arch (which used as type in locked sig file) from it neither.
For example, consider the case where you switch machines and want to share an include file between these machines. With the changes proposed in this patch series it will simply overwrite the file and remove the entries for the other machine.
I think the swith machines case could work in this patch series, It appends to the tail of the locked sig file, and not overwrite the other machine's sig if incremetnal dump is set. But I indeed understand what you worry about.
We could keep trying to patch up this code to cover every combination and eventuality but in the end, I believe the maintenance of this file should be something external, the sigs code should only be concerned with the generation of the core entries.
Completely agree. //Hongxu
Cheers, Richard
-- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
