On śro, 2014-07-23 at 14:21 -0500, Tom Zanussi wrote: > Sorry, I'm not seeing how this fixes the problem (best would be to > explain that in the patch description too), or for that matter, how to > reproduce the problem. Could you elaborate?
Right, the wording might be unfortunate and not reflect what actually happens behind the scenes. DirectImageCreator.__write_fstab() generates new /etc/fstab in sysroot. The contents are the original entries in /etc/fstab + the partitions listed in *.wks (skipping / and /boot). A backup of the original /etc/fstab is made in temp. A counterpart call to DirectImageCreator.__restore_fstab() brings back the original version into sysroot, so that the whole process does not leave any files in the original tree. The problem is that calling __restore_fstab() before __instimage.add_partition() brings back the original fstab before the partition file actually is built. As such, any extra partitions listed in *.wks never make it to /etc/fstab. For instance I add an extra user data partition like this: part /media/data --ondisk mmcblk0p --fstype=vfat --label data --... will not be reflected in /etc/fstab and not mounted when system is brought up. The patch resolves this problem. -- Maciej Borzęcki Senior Software Developer at Open-RnD Sp. z o.o., Poland www.open-rnd.pl mobile: +48 889 117 365, fax: +48 42 657 9079 Niniejsza wiadomość wraz z załącznikami może zawierać chronione prawem lub poufne informacje i została wysłana wyłącznie do wiadomości i użytku osób, do których została zaadresowana. Jeśli wiadomość została otrzymana przypadkowo zabrania się jej kopiowania lub rozsyłania do osób trzecich. W takim przypadku uprasza się o natychmiastowe zniszczenie wiadomości oraz poinformowanie nadawcy o zaistniałej sytuacji za pomocą wiadomości zwrotnej. Dziękujemy. This message, including any attachments hereto, may contain privileged or confidential information and is sent solely for the attention and use of the intended addressee(s). If you are not an intended addressee, you may neither use this message nor copy or deliver it to anyone. In such case, you should immediately destroy this message and kindly notify the sender by reply email. Thank you. -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
