On Sat, Jul 12, 2014 at 10:20 AM, João Henrique Ferreira de Freitas
<joa...@gmail.com> wrote:
>
> Hi Otavio
>
> Em 08-07-2014 22:33, Otavio Salvador escreveu:
>
>> Now talking about the patch itself, Joao, did you try to avoid the extra
>> fork calling echo? Using '-print0' option in find might help.
>
>
> Not until now. But I agree about your concern. So, instead of
>
>
> executable_files=$($SUDO_EXEC find $native_sysroot -type f -perm /111 -exec
> echo \'{}\' \;)
>
> Its better do:
>
> executable_files=$($SUDO_EXEC find $native_sysroot -type f -perm /111
> -printf "'%h/%f' ")
>
> No extra fork was used with -printf "'%h/%f' ".
>
> The argument -print0 is not an option because the output of find command
> will be 'path1 path2 path 3' a concatenation of strings not strings split by
> space and protected with ' '.
>
> Both results are valid. But the second is nicer. What do you think?Nice. > When I did this patch I was not thinking to solve all problems about spaces > in filename. However a deep dig is needed to track all points that have this > issue. Fully agree but this shouldn't deny this patch to be applied. It is a step further. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
