On Tue, 2014-06-10 at 10:42 -0600, Gary Thomas wrote: > On 2014-06-10 10:37, Mark Hatle wrote: > > On 6/10/14, 11:32 AM, Richard Purdie wrote: > >> When building on XFS filesystems, the resulting rpms can be corrupted > >> with the same inode number being used for multiple hardlinked files. > >> There are two fixes, one to stop rpm crashing when accessing a broken > >> binary rpm, the other to stop generating them in the first places. Full > >> descriptions in the patch headers. > >> > >> Signed-off-by: Richard Purdie <richard.pur...@linuxfoundation.org> > >> > >> diff --git a/meta/recipes-devtools/rpm/rpm/rpm-hardlink-segfault-fix.patch > >> b/meta/recipes-devtools/rpm/rpm/rpm-hardlink-segfault-fix.patch > >> new file mode 100644 > >> index 0000000..d49de6f > >> --- /dev/null > >> +++ b/meta/recipes-devtools/rpm/rpm/rpm-hardlink-segfault-fix.patch > >> @@ -0,0 +1,43 @@ > >> +We need to sanity check that the nlink size and our linksLeft counter > >> +do match. If an rpm is badly constucted with identical inode values > > > > s/constucted/constructed > > > >> +for multiple hardlinked files, such an rpm will overwise access memory > > > > s/overwise/otherwise > > > >> +out of array bounds and cause memory corruption and crashes. > >> + > >> +The fix is to add in the sanity check and exit if bad circumstances > >> +are found. We need to fix the caller to check the return code too. > >> + > >> +RP 10/6/1024 > > > > 2014? > > Perhaps even an ISO date (2014-06-10) since that's what's used everywhere > else (and it's not October yet, at least not on this side of the pond)
I do try and use ISO dates in patches after a comment from you a while back. On this occasion lets just say it wasn't the top thing on my mind (nor was spelling, clearly :/). I've been staring at debugging this issue for 48 hours and there is some pressure on for getting it fixed and several things unblocked. I wasn't feeling particularly well when I started and am not much better now so let me just say thanks for the fixes and leave this there :) Cheers, Richard -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
