On Wednesday 28 May 2014 23:53:51 João Henrique Ferreira de Freitas wrote: > If file_filter is set, git format-patch takes account but git rev-list > does not. So revlist is going to get with wrong revisions. And last_revision > will be updated with wrong revision. The next time that user run > combo-layer it complain about applying patches. > > So ensure that 'git rev-list' are using file_filter as 'git format-patch'. > > Signed-off-by: João Henrique Ferreira de Freitas <joa...@gmail.com> > --- > scripts/combo-layer | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/combo-layer b/scripts/combo-layer > index 9da1d3a..19d64e6 100755 > --- a/scripts/combo-layer > +++ b/scripts/combo-layer > @@ -395,7 +395,7 @@ def action_update(conf, args): > logger.debug("generated patch set:\n%s" % output) > patchlist = output.splitlines() > > - rev_cmd = 'git rev-list --no-merges ' + rev_cmd_range > + rev_cmd = "git rev-list --no-merges %s -- %s" % (rev_cmd_range, > file_filter) revlist = runcmd(rev_cmd, ldir).splitlines() > > # Step 3: Call repo specific hook to adjust patch
You're right, I'm not sure how we didn't pick up on this earlier. Thanks! Acked-by: Paul Eggleton <paul.eggle...@linux.intel.com> Cheers, Paul --------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core