On 15 April 2014 20:04, Paul Eggleton <paul.eggle...@linux.intel.com> wrote:
> On Wednesday 09 April 2014 22:25:31 Fathi Boudra wrote:
>> On 9 April 2014 22:15, Chris Larson <clar...@kergoth.com> wrote:
>> > On Wed, Apr 9, 2014 at 9:18 AM, Fathi Boudra <fathi.bou...@linaro.org>
>> >
>> > wrote:
>> >> On 9 April 2014 18:02, Chris Larson <clar...@kergoth.com> wrote:
>> >> > On Tue, Apr 8, 2014 at 10:16 AM, Fathi Boudra <fathi.bou...@linaro.org>
>> >> >
>> >> > wrote:
>> >> >> On 8 April 2014 20:05, Khem Raj <raj.k...@gmail.com> wrote:
>> >> >> > On Tue, Apr 8, 2014 at 7:00 AM, Fathi Boudra
>> >> >> > <fathi.bou...@linaro.org>
>> >> >> >
>> >> >> > wrote:
>> >> >> >> do_install() {
>> >> >> >>
>> >> >> >> - oe_runmake prefix="${prefix}" DESTDIR="${D}" install
>> >> >> >> + ${MAKE} NO_PYTHON=1 prefix=${prefix}
>> >> >> >> plugin_dir=${libdir}/trace-cmd/plugins DESTDIR=${D} install
>> >> >> >>
>> >> >> >> }
>> >> >> >
>> >> >> > can you explain/document this change
>> >> >>
>> >> >> sure. trace-cmd doesn't have a build system generated Makefile. It's
>> >> >> hand written.
>> >> >> To do the install properly, one has to pass prefix/plugin_dir.
>> >> >> In addition, the previous command in the recipe doesn't do the right
>> >> >> thing anymore (you'll end with duplicated prefix /usr/usr/).
>> >> >
>> >> > You don't need to avoid the use of oe_runmake to pass variables in,
>> >> > that's
>> >> > what EXTRA_OEMAKE is for :) See
>> >> > https://github.com/MentorEmbedded/meta-mentor/commit/4639877 for a
>> >> > version
>> >> > of this fix that uses it instead.
>> >>
>> >> You don't need oe_runmake or EXTRA_OEMAKE to properly build and
>> >> install the files in the right path either :)
>> >> You can even drop inherit pkgconfig pythonnative since they aren't
>> >> used. My version is also slightly shorter to achieve the same goal.
>> >
>> > oe_runmake is the convention used by nearly every recipe in oe-core.
>> > Breaking that convention for no good reason accomplishes nothing.
>>
>> you can argue as you prefer. reality is that using oe_runmake on this
>> particular software accomplishes nothing.
>
> It accomplishes as much as it does anywhere else. I don't see that this recipe
> needs to be special by not using it. In any case, you've run the recipe
> through oe-stylize to make it conform to OE style guidelines that that script
> handles, surely it's not a big thing to conform to this expected style as
> well?
In that case, you might be able to replace ${MAKE} by oe_runmake in
the patchset and everybody will be happy.
> Cheers,
> Paul
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
